image viewer: close button looks like closing the app #31

New issue

Closed

opened 2026-10-21 20:24:40 +00:00 by tlasol · 2 comments

tlasol commented

2026-10-21 20:24:40 +00:00

Member

expected:
it’s obvious the cross closes only the viewer. options:

make the viewer visually distinct from the app window (dimmed backdrop, padding, fullscreen pane, so the chat somehow is visible behind it)
move or restyle the close button so it doesn’t look like a window control
esc and click outside the image close the viewer

actual:
the cross is easy to mistake for closing the messenger

description: the viewer opens at the exact size of the messenger window (which is already confusing) and has a close cross in the top right corner. because the viewer fills the whole window, the cross looks like the button that closes the messenger itself, and it’s even more confusing expected: it’s obvious the cross closes only the viewer. options: - make the viewer visually distinct from the app window (dimmed backdrop, padding, fullscreen pane, so the chat somehow is visible behind it) - move or restyle the close button so it doesn’t look like a window control - esc and click outside the image close the viewer actual: the cross is easy to mistake for closing the messenger

tlasol added the

macos

ui/ux

labels

2026-10-21 20:24:40 +00:00

ann referenced this issue from a commit

2026-10-23 21:50:17 +00:00

The media viewer: arrow keys from the start, a click that zooms with zoom buttons in the header, its own close button on a backdrop the chat shows through, and no stickers among the photos (#29, #30, #31, #37). No change of its own: a record of a change that the shared worktree index swept into two other coders' commits while it was being staged -- the code, tests and smoke checks into ac1681e7 (stickers) and the catalogue strings (Close (Esc), Zoom in, Zoom out, Fit to window, in en.json and the six catalogues) into 08320a28 (room avatars).

ann referenced this issue from a commit

2026-10-23 21:50:17 +00:00

0.7.1-dev, a test build on libtacky develop b5fd9316 (the user, 2026-10-24: "mark it 0.7.1-dev, release gms apk, flatpak and windows standalone for now as its test"): the version in ui/package.json and its lock, src-tauri/tauri.conf.json, Cargo.toml and Cargo.lock, the CHANGELOG's 0.7.1-dev entry naming every forge issue it answers (#33, #47, #39, #38, #37, #44, #45, #48, #36, #32, #43, #29, #30, #31 fixed; #46 and #40 added), and the metainfo's development release, named 0.7.2~dev there because appstream sorts 0.7.1~dev below the 0.7.1 release (appstreamcli validate --no-net passes). The README's figures wait for the release. On the branch before the pin and this bump: make test-ui 2658 passed and 8 skipped, make check STRICT=1 clean, make test-shell 185 passed.

ann commented

2026-10-24 22:08:44 +00:00

Owner

The media viewer's close button is its own round one over the picture, on a backdrop the chat shows through, so it no longer looks like the app's close.

Fixed on develop in 64703a05, in the 0.7.1-dev test build (gms apk, Flatpak, Windows setup and portable zip) of 2026-10-24. Please reopen if it still misbehaves there.

The media viewer's close button is its own round one over the picture, on a backdrop the chat shows through, so it no longer looks like the app's close. Fixed on `develop` in 64703a05, in the 0.7.1-dev test build (gms apk, Flatpak, Windows setup and portable zip) of 2026-10-24. Please reopen if it still misbehaves there.

ann referenced this issue from a commit

2026-10-25 02:20:26 +00:00

The media viewer in Telegram's arrangement (the user, 2026-10-25: "now image viewer layout. file name - above 'You 25 October 2.4 MB' (bottom left). counter - after file info, in same area. control buttons, like zoom, copy, save - bottom right. close button - top right. top right - only close button, yes."). The sheet is bare as well as stage and own-close, so its header holds nothing and its title only names the dialog; the round close button sits alone at the top right of a new frame around the stage, 12 px in, and where the page draws the window buttons on Linux (data-csd) just under them, still clear of them (#31). A band along the bottom carries, at the left with 16 px gutters, the file's name (or the kind word) over author · date and time · size, each part only when known, followed by the counter, now "{n} of {total}" (already in all seven catalogues), and at the right zoom out, the percentage, zoom in, full screen, share, copy and save, each only where it applies as before; it wraps the tools under the file at phone width when both do not fit. A picture takes the whole frame with the band fading in over its lower edge in a translucent gradient, white text with a soft shadow, and a tap on the gradient is a tap on the backdrop; a video or a sound ends above the band, so the player's own controls are not under it. Full screen now takes the frame, so the close and the tools come along; zoom, pan, the click and double tap, the wheel, swipes, the window-level keys while on top with the focus on the stage, Escape's step back, and the failed and unsupported notices are unchanged. Tested in the container: make check STRICT=1 clean; make test-ui 196 files, 2701 passed, 8 skipped (new cases for the bare sheet with nothing slotted into its header and the close the only loose element, the band's name, author · date · size, "3 of 12" and the tools in order, a nameless single item, a video's and a sound's stage ending above the band; viewer-close-focus checks the close in the frame and the tools in the band); make build-mock; the WebKit smoke screens media viewer image and video at 1100 and 380 px in Night and Day and media viewer h264, 239 checks ok, asserting the close alone at the top right (clear of the window buttons where they are drawn), the file's lines and the counter at the bottom left, the tools at the bottom right in order and clear of the file, a video ending above the band, and the arrow keys and the close still working.

ann commented

2026-10-27 05:35:09 +00:00

Owner

Closing: answered above and no reply since; reopen if needed.

ann closed this issue

2026-10-27 05:35:09 +00:00