another-im/anotherim-js

Watch

Fork 2

Sign-up: a name with capitals ends signed in, not on "Connecting…" #88

Merged

ann merged 1 commit from ryoitsu69/anotherim-js:fix/sign-up-capitals into develop

2026-11-06 18:30:08 +00:00

ryoitsu69 commented

2026-11-06 17:50:43 +00:00

Contributor

After a sign-up with capitals in the name, the screen stays on "Connecting…" over an account that is already connected. This is what is left of #86, which I closed because 0.8.0-rc5 fixes the rest.

Cause

Registration.registeredJid builds the address from the form's username answer as typed. <aim-signin-card> keeps that in pending and looks it up in connState, an exact Map.get. Since rc5 Store.signIn normalises its own copy (59ccee91) and libtacky 1.2.0-rc4 names the account in lower case, so conn <State> comes under rc5_signup_test@chat.test while the card waits for Rc5_Signup_Test@chat.test. signed-in never comes, and the shell keeps the screen up on pendingSignIn. A restart opens the account normally.

Fix

registeredJid goes through normJid, the rule addressTarget and jidOf follow since ecce2f19. The name in the form still goes to the server as typed.

Testing

registration.test.ts and signin-card.test.ts each gain a test with a name with capitals, which no sign-up test had. Both fail on 5f1ef7e8.
make test-ui check: 5130 passed, 8 skipped, check clean. On Node 26 it needs NODE_OPTIONS=--no-webstorage: without it jid-case.test.ts fails on clean develop too, because localStorage is undefined under happy-dom.
On a local ejabberd 26.09 (anotherim-server b9e675dd), with a name with capitals:
- The released rc5 AppImage stays on "Connecting…" on the welcome screen. The server's log shows the session opened a second after the registration.
- A build of this branch opens at once, from the welcome screen and from Settings, Accounts, Add an account. Messages pass between the two accounts.

Not run: the Add account sheet in the released rc5, Android.

🤖 Generated with Claude Code

After a sign-up with capitals in the name, the screen stays on "Connecting…" over an account that is already connected. This is what is left of #86, which I closed because 0.8.0-rc5 fixes the rest. ## Cause `Registration.registeredJid` builds the address from the form's `username` answer as typed. `<aim-signin-card>` keeps that in `pending` and looks it up in `connState`, an exact `Map.get`. Since rc5 `Store.signIn` normalises its own copy (59ccee91) and libtacky 1.2.0-rc4 names the account in lower case, so `conn <State>` comes under `rc5_signup_test@chat.test` while the card waits for `Rc5_Signup_Test@chat.test`. `signed-in` never comes, and the shell keeps the screen up on `pendingSignIn`. A restart opens the account normally. ## Fix `registeredJid` goes through `normJid`, the rule `addressTarget` and `jidOf` follow since ecce2f19. The name in the form still goes to the server as typed. ## Testing - `registration.test.ts` and `signin-card.test.ts` each gain a test with a name with capitals, which no sign-up test had. Both fail on 5f1ef7e8. - `make test-ui check`: 5130 passed, 8 skipped, `check` clean. On Node 26 it needs `NODE_OPTIONS=--no-webstorage`: without it `jid-case.test.ts` fails on clean develop too, because `localStorage` is undefined under happy-dom. - On a local ejabberd 26.09 (anotherim-server b9e675dd), with a name with capitals: - The released rc5 AppImage stays on "Connecting…" on the welcome screen. The server's log shows the session opened a second after the registration. - A build of this branch opens at once, from the welcome screen and from Settings, Accounts, Add an account. Messages pass between the two accounts. Not run: the Add account sheet in the released rc5, Android. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

ryoitsu69 added 1 commit

2026-11-06 17:50:43 +00:00

Sign-up: a name with capitals ends signed in, not on "Connecting…". registeredJid built the address from the form's username answer as typed, and the sign-in card watches that string in connState, an exact lookup. Since 0.8.0-rc5 Store.signIn normalises its own copy and libtacky 1.2.0-rc4 names the account in lower case, so conn <State> comes under rc5_signup_test@chat.test while the card waits for Rc5_Signup_Test@chat.test: signed-in never comes, and the shell keeps the screen up over an account that is already connected, until the app is restarted. registeredJid now goes through normJid, the rule addressTarget and jidOf follow since ecce2f19; the name in the form still goes to the server as typed. registration.test.ts and signin-card.test.ts take a name with capitals, which no sign-up test did; both fail on 5f1ef7e8. On a local ejabberd 26.09 the released rc5 AppImage stays on "Connecting…" with a session open on the server, and a build with this change opens at once. CHANGELOG under Unreleased. 7829473bb1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

ann merged commit d618bd2081 into develop

2026-11-06 18:30:08 +00:00

ann referenced this pull request from a commit

2026-11-06 18:30:09 +00:00

Merge pull request 'Sign-up: a name with capitals ends signed in, not on "Connecting…"' (#88) from ryoitsu69/anotherim-js:fix/sign-up-capitals into develop

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

another-im/anotherim-js!88

No description provided.

Rows
Columns